Recover interactively when the folder is not specified or is wrong #147
+478
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45dcacd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
daniilsapa
reviewed
Dec 18, 2024
packages/steiger/src/features/choose-root-folder/choose-from-similar.ts
Outdated
Show resolved
Hide resolved
|
I've not finished reviewing yet but left some first comments |
|
Also, question, should this be included in the next minor release? If so, then we need to change the destination branch to |
|
I don't think this is particularly ground-breaking, so I wouldn't mind including it in 0.5.4 as well. Although we will have to change the changeset |
daniilsapa
reviewed
Dec 24, 2024
packages/steiger/src/features/choose-root-folder/choose-from-similar.ts
Outdated
Show resolved
Hide resolved
daniilsapa
previously approved these changes
Dec 27, 2024
commit: |
|
Yes, you're right 👍, I missed that point during the review |
daniilsapa
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40. I wanted to start adding some delight ✨ to the CLI, this is the first step.
If the person doesn't specify any folder, we will now check if there's a
srcorappin the current folder and suggest those. We will also suggest to run in the current folder. If it matches what the person wanted to do, then we will print what command they should run next time if they want to repeat it. If it doesn't, we will casually mention the correct usage and leave the person alone (without an error exit code).If the person specifies a folder, but it doesn't exist or is a file (for example, when they don't use terminal autocomplete and make a typo), then we will assume that most of what they wrote is correct and will try to correct typos. For example, if they wrote
pachages/stieger/scr, we can trace this path and realize that they probably meantpackages/steiger/srcand then suggest to run the command there.Screenshots
If no folder was specified and there are no obvious candidates in the current folder:
If that's not what the person wants:
When there's a
srcin the current folder:When they made a typo and there's an obvious candidate:
When they accept the suggestion, we're informing them of what command is actually being run now (so that they can copy it, for example):
Typos can occur in different path segments:
When there's a
distfolder, we don't consider it as a candidate because it's very unlikely that someone wants to checkdist:When there are several possible candidates that the person could mean: